- 19 Jan, 2015 1 commit
-
-
Jamalaka authored
-
- 10 Dec, 2014 1 commit
-
-
Jamalaka authored
-
- 09 Dec, 2014 1 commit
-
-
Jamalaka authored
-
- 10 Jun, 2014 13 commits
-
-
anthraxx authored
its not needed because OS is responsible to cleanup mem allocated by terminating process, but its still a good manner to explicitly free everything that gets allocated... yes this is "noise" if it terminates but neither does harm to feel being responsible to clean up everything ourselves. :) at least valgrind is silently happy :P :D
-
anthraxx authored
-
gnomus authored
nitpicking and better c standard compliant code let us... ...use the proper main(void) signature. ...use variable names which speak for their semantic content not their type, as types are explicitly declared. ...use perror() to signal the correct errno message upon error. ...move the password out of the running code, so we can change and find it easily. ...use exit() as it's a linear CLI tool, which can and should exit on certain failure/error states. ...decouple error handling from business logic. (e.g. getline() error handling and strcmp() for password check). ...not free() at the end of the program as it **is** and should **never** be necessary, since the OS **must** handle this.
-
Oliver Feldt authored
-
gnomus authored
using printf to avoid \n for pwd input message newline after "Please enter Password: " looks strange
-
anthraxx authored
-
gnomus authored
memleak bugfix + cleanup + Makefile - memleak bugfix as free() was missing - dont call malloc() manually (the old way getline() always called realloc() anyway because of the way the malloc() was written [did not allocate enought memory for the string]) - small minor cleanup - adding simple Makefile to build door challenge
-
anthraxx authored
-
anthraxx authored
-
anthraxx authored
-
anthraxx authored
- therefor if the program gets extended, its unlikly that someone will forget to call free() - also this gets rid of copy-paste free() calls (which look stupid)
-
anthraxx authored
- implicitly declaring library function is bad manner :)
-
anthraxx authored
- adding missing free() calls - dont malloc ourselves as getline() also does a malloc (and anyway called realloc before if the size_t was smaller then the actual len(input-line) to behaviour is the same!)
-
- 07 Jun, 2014 5 commits
- 06 Jun, 2014 4 commits